Reduce dependency install time and decrease docker image size #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
==========================================
- Coverage 70.69% 70.58% -0.11%
==========================================
Files 78 78
Lines 3638 3638
Branches 57 57
==========================================
- Hits 2572 2568 -4
- Misses 1063 1067 +4
Partials 3 3 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msaroufim
approved these changes
May 25, 2023
|
Well actually in this case we're not guaranteed to have the torch version that shows up in our requirements as the one that gets installed |
|
True. For this we need to freeze all version numbers of our dependencies which we should do in any case. |
|
@agunapal This fixes the nightly docker build: https://github.com/pytorch/serve/actions/runs/5085378605 |
agunapal
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the order of the installation of torchserve dependencies from "requirements.txt -> torch" into "torch -> requirements.txt". This speeds up the installation of the dependencies and reduces the docker CPU image size from 4.98GB to 2GB and GPU from 11.1GB to 8.4GB.
Fixes #2358
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
images size before:
CPU:
GPU:
images size after:
CPU:
GPU:
docker run --rm -it -p 8080:8080 -p 8081:8081 -p 8082:8082 -p 7070:7070 -p 7071:7071 2db5237a38ea
Checklist: